Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked group tabs #5886

Merged
merged 5 commits into from
May 16, 2024
Merged

Stacked group tabs #5886

merged 5 commits into from
May 16, 2024

Conversation

zakk4223
Copy link
Contributor

@zakk4223 zakk4223 commented May 5, 2024

Describe your PR, what does it fix/add?

Render the groupbar tabs vertically, like sway/i3's "stacked" windows.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Is it ready for merging, or does it need work?

Can be merged. Maybe the only thing missing is a way to toggle a group between 'tabbed' and 'stacked' dynamically? I have a few other dispatcher/group related things I may do so I'll bundle it up with those sometime in the future

@Ligthiago
Copy link
Contributor

For me tab names are a bit buggy. Same windows on both pics, but after switching to stacked second window tab shows name of first window.

norm
stkd

@zakk4223
Copy link
Contributor Author

zakk4223 commented May 5, 2024

Oops, missed an array index. Try now please

@Ligthiago
Copy link
Contributor

Yep, fine now

@MightyPlaza
Copy link
Contributor

not sure if intentional but onBeginWindowDragOnDeco and onEndWindowDragOnDeco haven't been updated, and line 469 is just bypassing the padding between bars check

Copy link
Contributor

@MightyPlaza MightyPlaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't build hyprland atm to test, but rest lgtm

@zakk4223
Copy link
Contributor Author

I'm not sure it's something to address in a PR like this, but I have to ask.

Does anyone actually use this drag+drop reordering onto the group bar functionality? And if you do how the hell? Every window drag converts to a floating window and blocks a huge part of the group bar. Your drops onto the group bar are effectively blind due to the window covering it.

Sway/i3 actually render indicators on the bar to tell you where the drop will go, but they also don't render the whole window during drag (actually they don't immediately pop dragged windows out of the layout and float them).

Mouse users, tell me your secret

@MightyPlaza
Copy link
Contributor

I'm not sure it's something to address in a PR like this, but I have to ask.

Does anyone actually use this drag+drop reordering onto the group bar functionality? And if you do how the hell? Every window drag converts to a floating window and blocks a huge part of the group bar. Your drops onto the group bar are effectively blind due to the window covering it.

Sway/i3 actually render indicators on the bar to tell you where the drop will go, but they also don't render the whole window during drag (actually they don't immediately pop dragged windows out of the layout and float them).

Mouse users, tell me your secret

I use it, most of the times with 3 or less windows.
It's not ideal, but I prefer it to the dispatchers.
(I realize it might become a bigger issue with stacked groupbars)

Window dragging opacity and relative/absolute size should prolly be configured (no just for group dragging).
Keeping the dragged window inside the group until the mouse leaves the groupbar makes sense, but would likely require changing a bunch of code.

@zakk4223
Copy link
Contributor Author

Come to find out the hidden tech of just setting all my floating windows fully transparent made it much easier to sort out dnd....

@MightyPlaza
Copy link
Contributor

rest lgtm

@MightyPlaza
Copy link
Contributor

if this is ready it's probably a good idea to ping vaxry before it needs rebasing

@vaxerski
Copy link
Member

whomst'd've said my name

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks more or less ok I guess just wiki mr

@zakk4223
Copy link
Contributor Author

hyprwm/hyprland-wiki#651

@vaxerski vaxerski merged commit ca0833c into hyprwm:main May 16, 2024
10 checks passed
cnt0 pushed a commit to cnt0/Hyprland that referenced this pull request May 16, 2024
* Stacked group tabs

* Fix index when creating groupbar title textures

* Changes for stacked dnd

* formatting

* Don't remove internal horizontal padding when calculating stacked bar
width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants